sandip-db commented on code in PR #45487:
URL: https://github.com/apache/spark/pull/45487#discussion_r1564863915
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlSuite.scala:
##########
@@ -2584,6 +2584,21 @@ class XmlSuite
val expectedResults = Seq.range(1, 18).map(Row(_))
checkAnswer(results, expectedResults)
+
+ val results2 = spark.read.format("xml")
+ .option("rowTag", "ROW")
+ .option("multiLine", "true")
Review Comment:
nit: remove
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlSuite.scala:
##########
@@ -2584,6 +2584,21 @@ class XmlSuite
val expectedResults = Seq.range(1, 18).map(Row(_))
checkAnswer(results, expectedResults)
+
+ val results2 = spark.read.format("xml")
+ .option("rowTag", "ROW")
+ .option("multiLine", "true")
+ .load(getTestResourcePath(resDir + "cdata-ending-eof.xml"))
+
+ val expectedResults2 = Seq.range(1, 18).map(Row(_))
+ checkAnswer(results2, expectedResults2)
+
+ val results3 = spark.read.format("xml")
+ .option("rowTag", "ROW")
+ .option("multiLine", "true")
Review Comment:
nit: remove
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/xml/XmlSuite.scala:
##########
@@ -2584,6 +2584,21 @@ class XmlSuite
val expectedResults = Seq.range(1, 18).map(Row(_))
checkAnswer(results, expectedResults)
+
+ val results2 = spark.read.format("xml")
+ .option("rowTag", "ROW")
+ .option("multiLine", "true")
+ .load(getTestResourcePath(resDir + "cdata-ending-eof.xml"))
+
+ val expectedResults2 = Seq.range(1, 18).map(Row(_))
+ checkAnswer(results2, expectedResults2)
+
+ val results3 = spark.read.format("xml")
+ .option("rowTag", "ROW")
+ .option("multiLine", "true")
+ .load(getTestResourcePath(resDir + "cdata-no-close.xml"))
+
+ val expectedResults3 = Seq.range(1, 18).map(Row(_))
Review Comment:
Add checkAnswer(results3, expectedResults3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
