HyukjinKwon commented on code in PR #46055:
URL: https://github.com/apache/spark/pull/46055#discussion_r1565268923


##########
.github/workflows/build_python_connect.yml:
##########
@@ -82,7 +82,11 @@ jobs:
           cp conf/log4j2.properties.template conf/log4j2.properties
           sed -i 's/rootLogger.level = info/rootLogger.level = warn/g' 
conf/log4j2.properties
           # Start a Spark Connect server
-          
PYTHONPATH="python/lib/pyspark.zip:python/lib/py4j-0.10.9.7-src.zip:$PYTHONPATH"
 ./sbin/start-connect-server.sh --driver-java-options 
"-Dlog4j.configurationFile=file:$GITHUB_WORKSPACE/conf/log4j2.properties" 
--jars `find connector/connect/server/target -name spark-connect*SNAPSHOT.jar`
+          
PYTHONPATH="python/lib/pyspark.zip:python/lib/py4j-0.10.9.7-src.zip:$PYTHONPATH"
 ./sbin/start-connect-server.sh \
+            --driver-java-options 
"-Dlog4j.configurationFile=file:$GITHUB_WORKSPACE/conf/log4j2.properties" \
+            --jars `find connector/connect/server/target -name 
spark-connect*SNAPSHOT.jar` \
+            --jars `connector/protobuf/target -name 
spark-protobuf*SNAPSHOT.jar` \
+            --jars `connector/avro/target -name spark-avro*SNAPSHOT.jar`
           # Make sure running Python workers that contains pyspark.core once. 
They will be reused.

Review Comment:
   ```suggestion
               --jars `find connector/connect/server/target -name 
spark-connect*SNAPSHOT.jar` \
               --jars `find connector/protobuf/target -name 
spark-protobuf*SNAPSHOT.jar` \
               --jars `find connector/avro/target -name spark-avro*SNAPSHOT.jar`
             # Make sure running Python workers that contains pyspark.core 
once. They will be reused.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to