Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/6456#discussion_r31351888
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/AppendOnlyMap.scala ---
@@ -32,12 +32,18 @@ import org.apache.spark.annotation.DeveloperApi
* size, which is guaranteed to explore all spaces for each key (see
* http://en.wikipedia.org/wiki/Quadratic_probing).
*
+ * The map can support up to 536870912 elements.
+ *
* TODO: Cache the hash values of each key? java.util.HashMap does that.
*/
@DeveloperApi
class AppendOnlyMap[K, V](initialCapacity: Int = 64)
extends Iterable[(K, V)] with Serializable {
- require(initialCapacity <= (1 << 29), "Can't make capacity bigger than
2^29 elements")
+
+ private val MAXIMUM_CAPACITY = (1 << 29)
--- End diff --
why not just put this in the object like you did in `PartitionedPairBuffer`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
