CTCC1 commented on code in PR #46045: URL: https://github.com/apache/spark/pull/46045#discussion_r1565134177
########## python/pyspark/sql/connect/functions/builtin.py: ########## @@ -2476,7 +2476,13 @@ def repeat(col: "ColumnOrName", n: Union["ColumnOrName", int]) -> Column: repeat.__doc__ = pysparkfuncs.repeat.__doc__ -def split(str: "ColumnOrName", pattern: str, limit: int = -1) -> Column: +def split( + str: "ColumnOrName", Review Comment: We might want to consider renaming variable that shadows python built-in such as `str`. It's annoying here that it breaks the usage of `isinstance(pattern, str)`, and I need to work around this by aliasing the python builtin (See the workaround comment in code). Given renaming variable would be a backwards incompatible change (for user code that uses kwargs) and needs further discussion, I won't add that here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
