nikolamand-db commented on code in PR #45856:
URL: https://github.com/apache/spark/pull/45856#discussion_r1566339138
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationRegexpExpressionsSuite.scala:
##########
@@ -116,30 +116,39 @@ class CollationRegexpExpressionsSuite
test("Support StringSplit string expression with collation") {
// Supported collations
- case class StringSplitTestCase[R](l: String, r: String, c: String, result:
R)
+ case class StringSplitTestCase[R](l: String, r: String, c: String, result:
R, limit: Int = -1)
val testCases = Seq(
- StringSplitTestCase("ABC", "[B]", "UTF8_BINARY", Seq("A", "C"))
+ StringSplitTestCase("ABC", "[B]", "UTF8_BINARY", Seq("A", "C")),
+ StringSplitTestCase("ABC", "[b]", "UTF8_BINARY", Seq("ABC")),
+ StringSplitTestCase("ABC", "[b]", "UTF8_BINARY_LCASE", Seq("A", "C")),
+ StringSplitTestCase("AAA", "[a]", "UTF8_BINARY_LCASE", Seq("", "", "",
"")),
+ StringSplitTestCase("AAA", "[b]", "UTF8_BINARY_LCASE", Seq("AAA")),
+ StringSplitTestCase("aAbB", "[ab]", "UTF8_BINARY_LCASE", Seq("", "", "",
"", "")),
Review Comment:
Rewritten tests, please check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
