gengliangwang commented on code in PR #46022:
URL: https://github.com/apache/spark/pull/46022#discussion_r1566448773
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectExecutionManager.scala:
##########
@@ -95,7 +95,7 @@ private[connect] class SparkConnectExecutionManager() extends
Logging {
sessionHolder.addExecuteHolder(executeHolder)
executions.put(executeHolder.key, executeHolder)
lastExecutionTimeMs = None
- logInfo(s"ExecuteHolder ${executeHolder.key} is created.")
+ logInfo(log"ExecuteHolder ${MDC(LogKey.EXECUTE_HOLDER_KEY,
executeHolder.key)} is created.")
Review Comment:
```suggestion
logInfo(log"ExecuteHolder ${MDC(LogKey.EXECUTE_KEY,
executeHolder.key)} is created.")
```
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectExecutionManager.scala:
##########
@@ -122,7 +122,7 @@ private[connect] class SparkConnectExecutionManager()
extends Logging {
if (executions.isEmpty) {
lastExecutionTimeMs = Some(System.currentTimeMillis())
}
- logInfo(s"ExecuteHolder $key is removed.")
+ logInfo(log"ExecuteHolder ${MDC(LogKey.EXECUTE_HOLDER_KEY, key)} is
removed.")
Review Comment:
```suggestion
logInfo(log"ExecuteHolder ${MDC(LogKey.EXECUTE_KEY, key)} is removed.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
