dongjoon-hyun commented on code in PR #46080:
URL: https://github.com/apache/spark/pull/46080#discussion_r1567130179
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala:
##########
@@ -4135,6 +4135,15 @@ object SQLConf {
.booleanConf
.createWithDefault(false)
+ val LEGACY_ORACLE_TIMESTAMP_MAPPING_ENABLED =
+ buildConf("spark.sql.legacy.oracle.timestampMapping.enabled")
+ .internal()
+ .doc("When true, TimestampType maps to TIMESTAMP in Oracle; otherwise, "
+
+ "TIMESTAMP WITH LOCAL TIME ZONE.")
+ .version("4.0.0")
+ .booleanConf
+ .createWithDefault(false)
Review Comment:
It seems that we need additional test coverage for `true`. The existing test
is only for `false`, isn't it?
```
SPARK-42627: Support ORACLE TIMESTAMP WITH LOCAL TIME ZONE (9 seconds, 536
milliseconds)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
