desmondcheongzx commented on code in PR #46071:
URL: https://github.com/apache/spark/pull/46071#discussion_r1567667735


##########
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala:
##########
@@ -766,6 +769,17 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
     }
   }
 
+  /**
+   * Ensure that the `singleVariantColumn` option cannot be used if there is 
also a user specified
+   * schema.
+   */
+  private def validateSingleVariantColumn(): Unit = {

Review Comment:
   If I understand correctly, in that case we'll also have to add the checks to 
the dataset readers, e.g. `def json(jsonDataset: Dataset[String]): DataFrame`, 
since these paths don't go through `load`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to