itholic commented on code in PR #46063:
URL: https://github.com/apache/spark/pull/46063#discussion_r1568162931
##########
python/pyspark/sql/tests/test_dataframe.py:
##########
@@ -1011,36 +1011,6 @@ def test_dataframe_error_context(self):
pyspark_fragment="eqNullSafe",
)
- # DataFrameQueryContext with pysparkLoggingInfo - and
- with self.assertRaises(AnalysisException) as pe:
- df.withColumn("and_invalid_type", df.id & "string").collect()
- self.check_error(
- exception=pe.exception,
- error_class="DATATYPE_MISMATCH.BINARY_OP_WRONG_TYPE",
- message_parameters={
- "inputType": '"BOOLEAN"',
- "actualDataType": '"BIGINT"',
- "sqlExpr": '"(id AND string)"',
- },
- query_context_type=QueryContextType.DataFrame,
- pyspark_fragment="and",
- )
-
- # DataFrameQueryContext with pysparkLoggingInfo - or
- with self.assertRaises(AnalysisException) as pe:
- df.withColumn("or_invalid_type", df.id | "string").collect()
- self.check_error(
- exception=pe.exception,
- error_class="DATATYPE_MISMATCH.BINARY_OP_WRONG_TYPE",
- message_parameters={
- "inputType": '"BOOLEAN"',
- "actualDataType": '"BIGINT"',
- "sqlExpr": '"(id OR string)"',
- },
- query_context_type=QueryContextType.DataFrame,
- pyspark_fragment="or",
- )
Review Comment:
In short, there was a change in the error message in the previous PR, but
the purpose of this work is to only provide additional error context to the
existing error message, so it was actually an unexpected change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
