mihailom-db commented on code in PR #46003: URL: https://github.com/apache/spark/pull/46003#discussion_r1568652210
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringExpressions.scala: ########## @@ -804,21 +804,26 @@ case class Overlay(input: Expression, replace: Expression, pos: Expression, len: override def dataType: DataType = input.dataType - override def inputTypes: Seq[AbstractDataType] = Seq(TypeCollection(StringType, BinaryType), - TypeCollection(StringType, BinaryType), IntegerType, IntegerType) + override def inputTypes: Seq[AbstractDataType] = Seq( Review Comment: Let's special case Overlay to only take first 2 parameters, as the last 2 might be implicitly cast to something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
