dbatomic commented on code in PR #46003:
URL: https://github.com/apache/spark/pull/46003#discussion_r1568832269
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CollationTypeCasts.scala:
##########
@@ -48,6 +48,10 @@ object CollationTypeCasts extends TypeCoercionRule {
case eltExpr: Elt =>
eltExpr.withNewChildren(eltExpr.children.head +:
collateToSingleType(eltExpr.children.tail))
+ case overlay: Overlay =>
+ overlay.withNewChildren(collateToSingleType(Seq(overlay.input,
overlay.replace))
+ ++ Seq(overlay.pos, overlay.len))
Review Comment:
Seq is just a trait, it depends on implementation whether it will
copy/traverse the collection (e.g. List and Array will do different thing).
If it is a single element append then :+ is more appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
