jiangzho commented on code in PR #4: URL: https://github.com/apache/spark-kubernetes-operator/pull/4#discussion_r1569568062
########## .gitignore: ########## @@ -2,7 +2,28 @@ *~ .java-version .DS_Store -.idea/ -.vscode /lib/ target/ + +# Gradle Files # +################ +.gradle +.m2 +.out/ +build +dependencies.lock +**/dependencies.lock +gradle/wrapper/gradle-wrapper.jar + +# IDE specific files/directories # +####################################### Review Comment: Despite not directly related - with plugin `idea` and `eclipse`, these files could be created after running init or build task. Would you suggest adding them with another PR as well ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
