cloud-fan commented on code in PR #45930:
URL: https://github.com/apache/spark/pull/45930#discussion_r1569819026
##########
core/src/main/scala/org/apache/spark/shuffle/sort/SortShuffleManager.scala:
##########
@@ -187,6 +187,7 @@ private[spark] class SortShuffleManager(conf: SparkConf)
extends ShuffleManager
shuffleBlockResolver.removeDataByMap(shuffleId, mapTaskId)
}
}
+ shuffleBlockResolver.removeShuffleToSkip(shuffleId)
Review Comment:
this is a weird place to do cleanup. Shall we cover all shuffle manager
implementations? Shall we do it in the caller of this `unregisterShuffle`
function?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
