pan3793 commented on code in PR #46150:
URL: https://github.com/apache/spark/pull/46150#discussion_r1573890525
##########
sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:
##########
@@ -3748,22 +3748,21 @@ class SQLQuerySuite extends QueryTest with
SharedSparkSession with AdaptiveSpark
test("SPARK-33084: Add jar support Ivy URI in SQL") {
val sc = spark.sparkContext
- val hiveVersion = "2.3.9"
// transitive=false, only download specified jar
- sql(s"ADD JAR
ivy://org.apache.hive.hcatalog:hive-hcatalog-core:$hiveVersion?transitive=false")
- assert(sc.listJars()
-
.exists(_.contains(s"org.apache.hive.hcatalog_hive-hcatalog-core-$hiveVersion.jar")))
+ sql(s"ADD JAR
ivy://org.springframework:spring-core:6.1.6?transitive=false")
+
assert(sc.listJars().exists(_.contains("org.springframework_spring-core-6.1.6.jar")))
+
assert(!sc.listJars().exists(_.contains("org.springframework_spring-jcl-6.1.6.jar")))
// default transitive=true, test download ivy URL jar return multiple jars
- sql("ADD JAR ivy://org.scala-js:scalajs-test-interface_2.12:1.2.0")
- assert(sc.listJars().exists(_.contains("scalajs-library_2.12")))
- assert(sc.listJars().exists(_.contains("scalajs-test-interface_2.12")))
-
- sql(s"ADD JAR ivy://org.apache.hive:hive-contrib:$hiveVersion" +
- "?exclude=org.pentaho:pentaho-aggdesigner-algorithm&transitive=true")
-
assert(sc.listJars().exists(_.contains(s"org.apache.hive_hive-contrib-$hiveVersion.jar")))
-
assert(sc.listJars().exists(_.contains(s"org.apache.hive_hive-exec-$hiveVersion.jar")))
-
assert(!sc.listJars().exists(_.contains("org.pentaho.pentaho_aggdesigner-algorithm")))
Review Comment:
this assertion is invalid. should be
```patch
- org.pentaho.pentaho_aggdesigner-algorithm
+ org.pentaho_pentaho-aggdesigner-algorithm
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
