dongjoon-hyun commented on code in PR #46149:
URL: https://github.com/apache/spark/pull/46149#discussion_r1574057309
##########
resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/KubernetesSuite.scala:
##########
@@ -589,7 +589,8 @@ class KubernetesSuite extends SparkFunSuite
assert(pod.getMetadata.getLabels.get("label2") === "label2-value")
assert(pod.getMetadata.getAnnotations.get("annotation1") ===
"annotation1-value")
assert(pod.getMetadata.getAnnotations.get("annotation2") ===
"annotation2-value")
- val appId =
pod.getMetadata.getAnnotations.get("yunikorn.apache.org/app-id")
+ val appIdLabel =
pod.getMetadata.getLabels.get("yunikorn.apache.org/app-id")
+ val appIdAnnotation =
pod.getMetadata.getAnnotations.get("yunikorn.apache.org/app-id")
Review Comment:
It would be better if we can move all yunikorn stuff into `YuniKornSuite` .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
