yaooqinn commented on code in PR #46153:
URL: https://github.com/apache/spark/pull/46153#discussion_r1574419574


##########
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/HiveSessionImplwithUGI.java:
##########
@@ -85,15 +73,6 @@ public String getDelegationToken() {
     return this.delegationTokenStr;
   }
 
-  @Override
-  protected synchronized void acquire(boolean userAccess) {
-    super.acquire(userAccess);
-    // if we have a metastore connection with impersonation, then set it first
-    if (sessionHive != null) {
-      Hive.set(sessionHive);

Review Comment:
   In the Hive repo, it implements this logic in its superclass 
`HiveSessionImpl`. In the Spark repo, we have this in HiveSessionImplwithUGI 
only but we mostly use `HiveSessionImpl` w/o this.
   
   The Hive metadata operations rely upon this, but on the spark side, the 
metadata operations have been overridden with catalog APIs.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to