panbingkun commented on code in PR #46130:
URL: https://github.com/apache/spark/pull/46130#discussion_r1574557636
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterSchedulerBackend.scala:
##########
@@ -255,9 +257,10 @@ private[spark] class KubernetesClusterSchedulerBackend(
.withLabel(SPARK_ROLE_LABEL, SPARK_POD_EXECUTOR_ROLE)
.withLabelIn(SPARK_EXECUTOR_ID_LABEL, executorIds: _*)
- if (!running.list().getItems().isEmpty()) {
- logInfo(s"Forcefully deleting ${running.list().getItems().size()}
pods " +
- s"(out of ${executorIds.size}) that are still running after
graceful shutdown period.")
+ if (!running.list().getItems.isEmpty) {
+ logInfo(log"Forcefully deleting ${MDC(COUNT,
running.list().getItems.size())} pods " +
+ log"(out of ${MDC(TOTAL, executorIds.size)}) that are still
running after graceful " +
Review Comment:
In order to reuse `TOTAL_SIZE` in `LogKey`, it was changed to `TOTAL`. At
the same time, `TOTAL` has already expressed the `all` concept, so in my
opinion, the suffix `_SIZE` has been removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
