stefankandic commented on code in PR #46083:
URL: https://github.com/apache/spark/pull/46083#discussion_r1575038248


##########
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala:
##########
@@ -320,6 +322,7 @@ private[spark] class HiveExternalCatalog(conf: SparkConf, 
hadoopConf: Configurat
       }
 
       table.copy(
+        schema = getHiveCompatibleSchema(table.schema),

Review Comment:
   actually i liked you previous comment about converting the schema at the 
similar place so I refactored table property creation to be done before the 
call to `createDataSourceTable`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to