gengliangwang commented on code in PR #46138:
URL: https://github.com/apache/spark/pull/46138#discussion_r1575117121
##########
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql:
##########
@@ -82,3 +82,8 @@ select 2.0 not between '1.0' and '3.0';
select 'b' not between 'a' and 'c';
select to_timestamp('2022-12-26 00:00:01') not between to_date('2022-03-01')
and to_date('2022-12-31');
select rand(123) not between 0.1 AND 0.2;
+
+-- Sanity test for legacy flag equating ! with NOT
+set spark.sql.legacy.bangEqualsNot=true;
+select 1 ! between 0 and 2;
Review Comment:
nit: let's add some tests cases that bang equals to not.
##########
sql/core/src/test/resources/sql-tests/inputs/predicate-functions.sql:
##########
@@ -82,3 +82,8 @@ select 2.0 not between '1.0' and '3.0';
select 'b' not between 'a' and 'c';
select to_timestamp('2022-12-26 00:00:01') not between to_date('2022-03-01')
and to_date('2022-12-31');
select rand(123) not between 0.1 AND 0.2;
+
+-- Sanity test for legacy flag equating ! with NOT
+set spark.sql.legacy.bangEqualsNot=true;
+select 1 ! between 0 and 2;
Review Comment:
nit: let's add some test cases that bang equals to not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
