dongjoon-hyun commented on code in PR #46163:
URL: https://github.com/apache/spark/pull/46163#discussion_r1575399787
##########
python/pyspark/sql/connect/functions/builtin.py:
##########
@@ -3804,12 +3804,14 @@ def sha2(col: "ColumnOrName", numBits: int) -> Column:
sha2.__doc__ = pysparkfuncs.sha2.__doc__
-def hll_sketch_agg(col: "ColumnOrName", lgConfigK: Optional[Union[int,
Column]] = None) -> Column:
+def hll_sketch_agg(
+ col: "ColumnOrName",
+ lgConfigK: Optional[Union[int, Column]] = None,
+) -> Column:
if lgConfigK is None:
return _invoke_function_over_columns("hll_sketch_agg", col)
else:
- _lgConfigK = lit(lgConfigK) if isinstance(lgConfigK, int) else
lgConfigK
Review Comment:
This is a logical code change, isn't it? If the previous code is a bug,
please file a JIRA and handle it separately, @zhengruifeng .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
