zeotuan commented on code in PR #46151:
URL: https://github.com/apache/spark/pull/46151#discussion_r1575423794
##########
mllib/src/main/scala/org/apache/spark/ml/util/Instrumentation.scala:
##########
@@ -253,6 +254,13 @@ private[spark] class OptionalInstrumentation private(
}
}
+ override def logInfo(logEntry: LogEntry): Unit = {
Review Comment:
This is so that classes that use the `OptionalInstrumentation` for logging
such as
[WeightedLeastSquares](mllib/src/main/scala/org/apache/spark/ml/optim/WeightedLeastSquares.scala),
[CrossValidator](mllib/src/main/scala/org/apache/spark/ml/tuning/CrossValidator.scala)
can also log MessageWithContext. Else I will get `Type Mismatched String =>
MessageWithContext`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
