cloud-fan commented on code in PR #45234:
URL: https://github.com/apache/spark/pull/45234#discussion_r1575603485
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/QueryStageExec.scala:
##########
@@ -198,18 +215,23 @@ case class ShuffleQueryStageExec(
reuse
}
- override def cancel(): Unit = shuffleFuture match {
- case action: FutureAction[MapOutputStatistics] if !action.isCompleted =>
- action.cancel()
- case _ =>
+ override def cancel(): Unit = {
Review Comment:
nit: it seems better to follow `def materialize` and `def doMaterialize`, to
have `def cancel` and `def doCancel`. We can put this materialization check in
`def cancel`, and maybe more common logic related to cancelation in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
