uros-db commented on code in PR #46165:
URL: https://github.com/apache/spark/pull/46165#discussion_r1575760634
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/maskExpressions.scala:
##########
@@ -84,7 +86,7 @@ object MaskExpressionBuilder extends ExpressionBuilder {
val digitCharArg = InputParameter("digitChar",
Some(Literal(Mask.MASKED_DIGIT)))
val otherCharArg = InputParameter(
"otherChar",
- Some(Literal(Mask.MASKED_IGNORE, StringType)))
+ Some(Literal(Mask.MASKED_IGNORE, SQLConf.get.defaultStringType)))
Review Comment:
update: I fixed this in the latest commit, but I don't like the idea of
doing this manually
instead, I think we should consider updating `literals.scala` to construct
string literals with respect to `defaultStringType` instead of `StringType`
if that sound good @cloud-fan, then I'll get to that a separate effort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
