grundprinzip commented on code in PR #46125:
URL: https://github.com/apache/spark/pull/46125#discussion_r1576480636
##########
python/pyspark/sql/connect/streaming/worker/foreach_batch_worker.py:
##########
@@ -76,16 +73,21 @@ def process(df_id, batch_id): # type:
ignore[no-untyped-def]
func(batch_df, batch_id)
print(f"{log_name} Completed batch {batch_id} with DF id {df_id}")
- while True:
- df_ref_id = utf8_deserializer.loads(infile)
- batch_id = read_long(infile)
- # Handle errors inside Python worker. Write 0 to outfile if no errors
and write -2 with
- # traceback string if error occurs.
- try:
+ try:
+ func = worker.read_command(pickle_ser, infile)
+ write_int(0, outfile)
+ outfile.flush()
+
+ while True:
+ df_ref_id = utf8_deserializer.loads(infile)
+ batch_id = read_long(infile)
+ # Handle errors inside Python worker. Write 0 to outfile if no
errors and write -2 with
+ # traceback string if error occurs.
process(df_ref_id, int(batch_id))
write_int(0, outfile)
- except BaseException as e:
- handle_worker_exception(e, outfile)
+ outfile.flush()
+ except BaseException as e:
Review Comment:
I think it would be better to use `Exception` because BaseException would
only cover built-in exceptions. But we should probably handle all exceptions
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
