pan3793 commented on code in PR #46184:
URL: https://github.com/apache/spark/pull/46184#discussion_r1576715545
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverServiceFeatureStep.scala:
##########
@@ -87,16 +77,19 @@ private[spark] class DriverServiceFeatureStep(
.withName(DRIVER_PORT_NAME)
.withPort(driverPort)
.withNewTargetPort(driverPort)
+ .withProtocol("TCP")
Review Comment:
Not related to the feature proposed by this PR, I just found our internal
cluster(1.19, I know Spark already dropped official support for such an old
version) complains `protocol` is omitted and failed to create resources without
this change. If this change is acceptable, I can submit it in an independent PR.
```
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: -HTTP START-
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: > PATCH
https://****.org:6443/api/v1/namespaces/spark/services/spark-8e2c0b8f0ba4d21f-driver-svc?fieldManager=fabric8&force=true
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: > Authorization: Bearer
*********
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: > User-Agent:
fabric8-kubernetes-client/6.12.1
24/04/23 23:48:25 TRACE HttpLoggingInterceptor:
{"apiVersion":"v1","kind":"Service","metadata":{"labels":{"spark-app-selector":"spark-0d5c3db763904e7585d9801295ded9ed"},"name":"spark-8e2c0b8f0ba4d21f-driver-svc","ownerReferences":[{"apiVersion":"v1","kind":"Pod","controller":true,"name":"org-apache-spark-examples-driversubmissiontest-ee4d378f0ba4d21a-driver","uid":"e29f255a-dd1f-45c3-89c4-1c30e1b51d6e"}]},"spec":{"clusterIP":"None","ports":[{"name":"driver-rpc-port","port":7078,"targetPort":7078},{"name":"blockmanager","port":7079,"targetPort":7079},{"name":"spark-ui","port":4040,"targetPort":4040}],"selector":{"spark-version":"4.0.0-SNAPSHOT","spark-app-selector":"spark-0d5c3db763904e7585d9801295ded9ed","spark-app-name":"org-apache-spark-examples-driversubmissiontest","spark-role":"driver"}}}
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: < 500 Internal Server Error
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: < cache-control: no-cache,
private
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: < content-length: 229
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: < content-type:
application/json
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: < date: Tue, 23 Apr 2024
15:48:25 GMT
24/04/23 23:48:25 TRACE HttpLoggingInterceptor:
{"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"failed
to create typed patch object: .spec.ports: element 0: associative list with
keys has an element that omits key field \"protocol\"","code":500}
24/04/23 23:48:25 TRACE HttpLoggingInterceptor: -HTTP END-
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
