viirya commented on PR #19: URL: https://github.com/apache/spark-connect-go/pull/19#issuecomment-2073619182
Got it. I didn't know the actual meaning of `v34` so I thought that you had v1, v2, ...v34 before. I am also not sure why the version number is embedded into the Go module name. Is it a common practice seen on other Go modules too? So once this Go library has v2 release, you will go to increase `v1` to `v2` in the module name again? I am not familiar with how Go module naming policy. I try to compare this with JVM package name and release version. For example, we don't have 3.4 in Spark JVM package name actually. So I'm wondering if it makes sense to remove the version number `v34` from this Go module name? 🤔 Of course it is commonly seen in other Go modules, then it is okay to rename it from `v34` to `v1`. It is also better to let other contributors of this Go library to take a look too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
