gengliangwang commented on code in PR #46192:
URL: https://github.com/apache/spark/pull/46192#discussion_r1578584591


##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBFileManager.scala:
##########
@@ -469,9 +475,10 @@ class RocksDBFileManager(
             log"version ${MDC(FILE_VERSION, version)}", e)
       }
     }
-    logInfo(s"Deleted ${filesToDelete.size - failedToDelete} files (failed to 
delete" +
-      s"$failedToDelete files) not used in versions >= $minVersionToRetain")
-
+    logInfo(log"Deleted ${MDC(NUM_FILES, filesToDelete.size - failedToDelete)} 
files " +
+      log"(failed to delete" +
+      log"${MDC(NUM_FILES_FAILED_TO_DELETE, failedToDelete)} files) " +
+      log"not used in versions >= ${MDC(VERSION_NUMBER, minVersionToRetain)}")

Review Comment:
   MIN_VERSION_NUMBER?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to