dongjoon-hyun commented on code in PR #46211:
URL: https://github.com/apache/spark/pull/46211#discussion_r1578613668
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2642,9 +2642,6 @@ class HiveDDLSuite
sql("CREATE TABLE t3 (v VOID) USING hive")
checkAnswer(sql("SELECT * FROM t3"), Seq.empty)
-
- sql("CREATE TABLE t4 (v VOID)")
- checkAnswer(sql("SELECT * FROM t4"), Seq.empty)
Review Comment:
This is a duplication in terms of Hive table capability test.
Instead, this is a test coverage of
`spark.sql.legacy.createHiveTableByDefault` which is covered already in SQL
module like `PlanResolutionSuite`. We can remove this safely.
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -2642,9 +2642,6 @@ class HiveDDLSuite
sql("CREATE TABLE t3 (v VOID) USING hive")
checkAnswer(sql("SELECT * FROM t3"), Seq.empty)
-
- sql("CREATE TABLE t4 (v VOID)")
- checkAnswer(sql("SELECT * FROM t4"), Seq.empty)
Review Comment:
This is a duplication in terms of Hive table capability test.
Instead, this is a test coverage of
`spark.sql.legacy.createHiveTableByDefault` which is covered already in SQL
module like `PlanResolutionSuite`. We can remove this safely from `hive` module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
