panbingkun commented on code in PR #46193:
URL: https://github.com/apache/spark/pull/46193#discussion_r1578623558
##########
common/utils/src/test/scala/org/apache/spark/util/StructuredLoggingSuite.scala:
##########
@@ -144,6 +146,22 @@ trait LoggingSuiteBase
}
}
+ // An enumeration value that is not defined in `LogKey`, you can define it
anywhere
+ private val externalLogKey = LogKey.VALUE
+ private val externalLog = log"${MDC(externalLogKey, "External log
message.")}"
+ test("Logging with external LogKey") {
Review Comment:
@gengliangwang
What do you think of the current modification approach?
If we define it as `a string`, it feels like there is `no binding
requirement` for `LogKey` at all
Perhaps we need more eyes to review the changes above?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
