Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31370480
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
}
}
+// Helper class that ensures a ManagedBuffer is released on
InputStream.close()
+private class WrappedInputStream(
+ delegate: InputStream, buf: ManagedBuffer, var
currentResult: FetchResult)
--- End diff --
Why do we need to pass `currentResult` here? It's not obvious on first
read and I'm worried that someone might remove it by accident unless we add a
comment explaining why we need to keep it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
