beliefer commented on code in PR #46226:
URL: https://github.com/apache/spark/pull/46226#discussion_r1580338925
##########
sql/core/src/test/scala/org/apache/spark/sql/DataFrameWindowFramesSuite.scala:
##########
@@ -570,4 +592,30 @@ class DataFrameWindowFramesSuite extends QueryTest with
SharedSparkSession {
}
}
}
+
+ test("SPARK-34227: WindowFunctionFrame should clear its states during
preparation") {
+ // This creates a single partition dataframe with 3 records:
+ // "a", 0, null
+ // "a", 1, "x"
+ // "b", 0, null
+ val df = spark.range(0, 3, 1, 1).select(
+ when($"id" < 2, lit("a")).otherwise(lit("b")).as("key"),
+ ($"id" % 2).cast("int").as("order"),
+ when($"id" % 2 === 0, lit(null)).otherwise(lit("x")).as("value"))
+
+ val window1 = Window.partitionBy($"key").orderBy($"order")
+ .rowsBetween(Window.unboundedPreceding, Window.unboundedFollowing)
+ val window2 = Window.partitionBy($"key").orderBy($"order")
+ .rowsBetween(Window.unboundedPreceding, Window.currentRow)
+ checkAnswer(
+ df.select(
+ $"key",
+ $"order",
+ nth_value($"value", 1, ignoreNulls = true).over(window1),
Review Comment:
This test case used to test window frame too, please refer
https://github.com/apache/spark/pull/31325/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
