Github user massie commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31371387
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -313,6 +303,33 @@ final class ShuffleBlockFetcherIterator(
}
}
+// Helper class that ensures a ManagedBuffer is released on
InputStream.close()
+private class WrappedInputStream(
+ delegate: InputStream, buf: ManagedBuffer, var
currentResult: FetchResult)
--- End diff --
I looked at the style guide and used the recommendation for `def`
parameters (which are aligned with the definition). I didn't see that I should
use the Scala Style Guide; I'll fix this. Thanks for point it out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
