beliefer commented on code in PR #46263:
URL: https://github.com/apache/spark/pull/46263#discussion_r1582090760
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -86,6 +87,17 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with
PredicateHelper with J
private def extractSelectiveFilterOverScan(
plan: LogicalPlan,
filterCreationSideKey: Expression): Option[(Expression, LogicalPlan)] = {
+
+ def canExtractRight(joinType: JoinType): Boolean = joinType match {
+ case Inner | LeftSemi | RightOuter => true
+ case _ => false
+ }
+
+ def canExtractLeft(joinType: JoinType): Boolean = joinType match {
+ case Inner | LeftSemi | LeftOuter | LeftAnti => true
+ case _ => false
+ }
Review Comment:
Shall we add the two methods into `joins.scala`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
