pan3793 commented on code in PR #46184:
URL: https://github.com/apache/spark/pull/46184#discussion_r1584062659
##########
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala:
##########
@@ -73,7 +73,8 @@ private[spark] class KubernetesDriverBuilder {
new HadoopConfDriverFeatureStep(conf),
new KerberosConfDriverFeatureStep(conf),
new PodTemplateConfigMapStep(conf),
- new LocalDirsFeatureStep(conf)) ++ userFeatures
+ new LocalDirsFeatureStep(conf),
+ new DriverIngressFeatureStep(conf)) ++ userFeatures
Review Comment:
> I expected a few minutes delays for only K8s ingress entity creations.
that surprises me, in our cluster, the overhead of ingress creation is
negligible.
I tested with ingress enabled/disabled 5 times in internal cluster to
measure the job submission time by `spark.app.startTime` -
`spark.app.submitTime`.
ingress enabled: 20715, 24954, 17129, 16631, 16076
ingress disabled: 20246, 20262, 17176, 18633, 19962
the difference is majorly caused by Pod creation, ingress creation is
negligible.
if the ingress creation is too heavy, option 2 is the only choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
