TakawaAkirayo commented on code in PR #46182:
URL: https://github.com/apache/spark/pull/46182#discussion_r1584077843
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SparkConnectServer.scala:
##########
@@ -36,21 +32,21 @@ object SparkConnectServer extends Logging {
try {
try {
SparkConnectService.start(session.sparkContext)
- SparkConnectService.server.getListenSockets.asScala.foreach { sa =>
- val isa = sa.asInstanceOf[InetSocketAddress]
- logInfo(
- log"Spark Connect server started at: " +
- log"${MDC(HOST, isa.getAddress.getHostAddress)}:${MDC(PORT,
isa.getPort)}")
- }
+ val isa = SparkConnectService.bindingAddress
Review Comment:
> High level, I think this change is fine, I'm mostly wondering if there is
a case where we would have multiple listen sockets, e.g. listening on multiple
devices?
@grundprinzip Yes, if we want to listen on all of the network interfaces in
a machine to accept connections from any network, then we can add multiple
addresses to let the Server listen on.
For SparkConnectService, the NettyServer is built with single address, so
the getListenSockets it should only have one item
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
