HyukjinKwon commented on code in PR #46298: URL: https://github.com/apache/spark/pull/46298#discussion_r1584287016
########## .github/workflows/build_python_connect35.yml: ########## @@ -0,0 +1,135 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +name: Build / Spark Connect Python-only (master-server, 35-client, Python 3.11) + +on: + push: + branches: + - '**' + +jobs: + # Build: build Spark and run the tests for specified modules using SBT + build: + name: "Build modules: pyspark-connect" + runs-on: ubuntu-latest + timeout-minutes: 300 + steps: + - name: Checkout Spark repository + uses: actions/checkout@v4 + - name: Cache SBT and Maven + uses: actions/cache@v4 + with: + path: | + build/apache-maven-* + build/*.jar + ~/.sbt + key: build-spark-connect-python-only-${{ hashFiles('**/pom.xml', 'project/build.properties', 'build/mvn', 'build/sbt', 'build/sbt-launch-lib.bash', 'build/spark-build-info') }} + restore-keys: | + build-spark-connect-python-only- + - name: Cache Coursier local repository + uses: actions/cache@v4 + with: + path: ~/.cache/coursier + key: coursier-build-spark-connect-python-only-${{ hashFiles('**/pom.xml') }} + restore-keys: | + coursier-build-spark-connect-python-only- + - name: Install Java 17 + uses: actions/setup-java@v4 + with: + distribution: zulu + java-version: 17 + - name: Install Python 3.11 + uses: actions/setup-python@v5 + with: + python-version: '3.11' + architecture: x64 + - name: Build Spark + run: | + ./build/sbt -Phive Test/package + - name: Install Python dependencies + run: | + pip install -r dev/requirements.txt + - name: Run tests Review Comment: Actually once we separate the steps, the processes between steps are terminated ... so I can't separate them because we should run the server IIRC. Maybe I can separate ``` "Start connect service" "Run .... tests" ``` and ``` "Re-start connect service in ..." "Run ... tests" ``` lemme try this later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
