HyukjinKwon commented on code in PR #46328:
URL: https://github.com/apache/spark/pull/46328#discussion_r1586971280
##########
python/packaging/classic/setup.py:
##########
@@ -307,6 +307,7 @@ def run(self):
"pyspark.errors",
"pyspark.errors.exceptions",
"pyspark.examples.src.main.python",
+ "pyspark.errors.data",
],
include_package_data=True,
Review Comment:
There is a test at
https://github.com/apache/spark/blob/master/dev/pip-sanity-check.py but that
only runs a basic test that does not import `pyspark.errors` whereas
https://github.com/apache/spark/actions/workflows/build_python_connect.yml
tests its full compatibility (only for `pyspark-connect` package though.
##########
python/packaging/classic/setup.py:
##########
@@ -307,6 +307,7 @@ def run(self):
"pyspark.errors",
"pyspark.errors.exceptions",
"pyspark.examples.src.main.python",
+ "pyspark.errors.data",
],
include_package_data=True,
Review Comment:
There is a test at
https://github.com/apache/spark/blob/master/dev/pip-sanity-check.py but that
only runs a basic test that does not import `pyspark.errors` whereas
https://github.com/apache/spark/actions/workflows/build_python_connect.yml
tests its full compatibility (only for `pyspark-connect` package though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
