Github user rezazadeh commented on the pull request:
https://github.com/apache/spark/pull/6213#issuecomment-106980262
Hi @debasish83 thank you for this PR. As it stands, it has too many
components, which it makes it hard to review individual contributions. @mengxr
and I spoke about this, and are wondering if you'd like to split it up to
smaller PRs. In order, the PRs would be the following:
1) Adding rowSimilarities() for *just* cosine similarity (more similarity
types adds extra reviewing, so please leave those out). Once this is done, then:
2) Adding similarProducts and similarUsers to MatrixFactorizationModel,
once this is done, then:
3) Adding different similarity kernels
Could you please close this PR and submit the above in order, one at a
time? We should work on each in order, i.e. wait for one to be merged before
the next one is started to be reviewed. The relevant JIRAs are 1) SPARK-4823,
2) SPARK-4675, and 3) is new.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
