panbingkun commented on code in PR #46402: URL: https://github.com/apache/spark/pull/46402#discussion_r1591720244
########## dev/test-dependencies.sh: ########## @@ -31,7 +31,7 @@ export LC_ALL=C # NOTE: These should match those in the release publishing script, and be kept in sync with # dev/create-release/release-build.sh HADOOP_MODULE_PROFILES="-Phive-thriftserver -Pkubernetes -Pyarn -Phive \ - -Pspark-ganglia-lgpl -Pkinesis-asl -Phadoop-cloud" + -Pspark-ganglia-lgpl -Pkinesis-asl -Phadoop-cloud -Pjvm-profiler" Review Comment: Okay, I will remove it. But I have a question. If the `end user` wants to use `spark-profiler` to analyze the `executor`, does he download 'me.bechberger:ap-loader-all:xxx' from the `maven central repository` and use it together with module `spark-profiler`? If that's the way it used to be, I am fine to it. Maybe we need to add detailed guide in some document? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
