panbingkun commented on code in PR #46390: URL: https://github.com/apache/spark/pull/46390#discussion_r1591904228
########## core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java: ########## @@ -17,21 +17,22 @@ package org.apache.spark.util.collection.unsafe.sort; +import java.io.*; Review Comment: Is it the `import order of the file header`, or from `org.slf4j.Logger & org.slf4j.LoggerFactory` to `org.apache.spark.internal.Logger &org.apache.spark.internal.LoggerFactory` The later change is to prohibit the import of `org.slf4j.Logger & org.slf4j.LoggerFactory` in java code later, so as to prevent subsequent developers from introducing`org.slf4j.Logger & org.slf4j.LoggerFactory` again, thus writing inconsistent logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
