grundprinzip commented on code in PR #45481:
URL: https://github.com/apache/spark/pull/45481#discussion_r1592071117
##########
python/pyspark/sql/connect/dataframe.py:
##########
@@ -1775,6 +1775,10 @@ def _to_table(self) -> Tuple["pa.Table",
Optional[StructType]]:
assert table is not None
return (table, schema)
+ def _toArrow(self) -> "pa.Table":
+ table = self._to_table()[0]
Review Comment:
nit: Using this notion, makes the code a bit more readable and makes sure it
fails if _to_table ever changes the tuple size, and thus behavior.
```suggestion
table, _ = self._to_table()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
