cxzl25 commented on code in PR #46273:
URL: https://github.com/apache/spark/pull/46273#discussion_r1592206866
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/adaptive/AdaptiveQueryExecSuite.scala:
##########
@@ -2502,6 +2502,26 @@ class AdaptiveQueryExecSuite
}
}
+ test("SPARK-48037: Fix SortShuffleWriter lacks shuffle write related metrics
" +
+ "resulting in potentially inaccurate data") {
+ withTable("t3") {
+ withSQLConf(
+ SQLConf.ADAPTIVE_EXECUTION_ENABLED.key -> "true",
+ SQLConf.SHUFFLE_PARTITIONS.key -> "16777217") {
+ sql("CREATE TABLE t3 USING PARQUET AS SELECT id FROM range(2)")
+ val (plan, adaptivePlan) = runAdaptiveAndVerifyResult(
+ """
+ |SELECT id, count(*)
+ |FROM t3
+ |GROUP BY id
+ |LIMIT 1
+ |""".stripMargin, skipCheckAnswer = true)
Review Comment:
Because AQE is disabled when checking the results, it will have many
partitions, and the order is not guaranteed at this time. When AQE is enabled,
it will be merged into one partition.
```sql
set spark.sql.adaptive.enabled=false;
set spark.sql.shuffle.partitions=1000;
create table foo as select id from range(2);
select id, count(*) from foo group by id limit 1;
```
output
```
1 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
