GideonPotok commented on PR #46404: URL: https://github.com/apache/spark/pull/46404#issuecomment-2099074984
> kudos for your effort on this ticket! I left some comments > > also, please try to ensure that your code doesn't introduce any breaking changes (for example, I see that `SQLQueryTestSuite` has a failing test for `Mode`) before requesting thorough review > > however, it's also good to verify the approach as soon as possible - so I would advise making these fixes and committing the benchmark results @uros-db Thanks for the review! I hear you that I should have waited before I brought in the other reviewers. Thanks for initial feedback! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
