hvanhovell commented on code in PR #46245:
URL: https://github.com/apache/spark/pull/46245#discussion_r1594229607
##########
connector/connect/common/src/main/protobuf/spark/connect/expressions.proto:
##########
@@ -379,6 +380,15 @@ message ScalarScalaUDF {
bool nullable = 4;
}
+message ScalaUDAF {
+ // (Required) Serialized JVM object of the Aggregator instance, including
buffer and output encoders
+ bytes payload = 1;
+ // (Required) Input type of the UDAF
+ DataType inputType = 2;
+ // (Required) True if the UDAF can return null value
+ bool nullable = 3;
Review Comment:
For the record we should not rely on the payload for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
