cloud-fan commented on code in PR #46443:
URL: https://github.com/apache/spark/pull/46443#discussion_r1594911102
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/With.scala:
##########
@@ -92,6 +95,26 @@ object With {
val commonExprRefs = commonExprDefs.map(new CommonExpressionRef(_))
With(replaced(commonExprRefs), commonExprDefs)
}
+
+ private def containsUnsupportedRef(
+ expr: Expression,
+ commonExprIds: Set[CommonExpressionId]
+ ): Boolean = {
+ expr match {
+ case _ if !expr.containsPattern(COMMON_EXPR_REF) => false
+ case w: With => containsUnsupportedAggExpr(w)
Review Comment:
Shall we remove this case? I think it's possible that the inner With has
references to the outer With's common expressions, and we should detect that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
