gengliangwang commented on code in PR #46450: URL: https://github.com/apache/spark/pull/46450#discussion_r1594919483
########## sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java: ########## @@ -69,7 +72,8 @@ public ClassicTableTypeMapping() { public String[] mapToHiveType(String clientTypeName) { Collection<String> hiveTableType = clientToHiveMap.get(clientTypeName.toUpperCase()); if (hiveTableType == null) { - LOG.warn("Not supported client table type " + clientTypeName); + LOG.warn("Not supported client table type {}", + MDC.of(LogKeys.CLASSIS_TABLE_TYPE$.MODULE$, clientTypeName)); Review Comment: Seem there is a typo `CLASSIC`. Let's simply use `TABLE_TYPE` for all the keys in this file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org