dongjoon-hyun commented on code in PR #46506:
URL: https://github.com/apache/spark/pull/46506#discussion_r1595628352
##########
common/network-common/src/main/java/org/apache/spark/network/client/TransportClientFactory.java:
##########
@@ -169,8 +169,10 @@ public TransportClient createClient(String remoteHost, int
remotePort, boolean f
// this code was able to update things.
TransportChannelHandler handler = cachedClient.getChannel().pipeline()
.get(TransportChannelHandler.class);
- synchronized (handler) {
- handler.getResponseHandler().updateTimeOfLastRequest();
+ if (handler != null) {
Review Comment:
I'm not sure if this is a safe replacement.
Although I don't know your code, if we need to check nullability, shall we
do inside `synchronized` block?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
