dongjoon-hyun commented on code in PR #46518:
URL: https://github.com/apache/spark/pull/46518#discussion_r1596102379
##########
connector/connect/common/src/main/protobuf/spark/connect/relations.proto:
##########
@@ -467,7 +467,9 @@ message Sample {
// (Optional) Whether to sample with replacement.
optional bool with_replacement = 4;
- // (Optional) The random seed.
+ // (Required) The random seed.
+ // This filed is required to avoid generate mutable dataframes (see
SPARK-48184 for details),
+ // however, still keep it 'optional' here for backward compatibility.
optional int64 seed = 5;
Review Comment:
Ya, this looks like inevitable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
