uros-db commented on code in PR #46511:
URL: https://github.com/apache/spark/pull/46511#discussion_r1596332638
##########
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java:
##########
@@ -215,43 +215,6 @@ public void contains() {
assertFalse(fromString("大千世界").contains(fromString("大千世界好")));
}
- @Test
- public void containsInLowerCase() {
Review Comment:
starting at https://issues.apache.org/jira/browse/SPARK-47410, we've
separated collation-related UTF8String logic away from `UTF8String.java` and
into `CollationSupport.java`
these changes for UTF8_BINARY_LCASE have nothing to do with the original
UTF8String implementation, so all tests are now found only in
CollationSupportSuite (instead of UTF8StringSuite) - we don't have a
UTF8LCASEStringSuite, and I don't think we need one, so CollationSupportSuite
should satisfy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
