pan3793 commented on code in PR #42493:
URL: https://github.com/apache/spark/pull/42493#discussion_r1596992306
##########
assembly/pom.xml:
##########
@@ -75,11 +75,7 @@
<version>${project.version}</version>
</dependency>
- <!--
- Because we don't shade dependencies anymore, we need to restore Guava to
compile scope so
- that the libraries Spark depend on have it available. We'll package the
version that Spark
- uses (14.0.1) which is not the same as Hadoop dependencies, but works.
- -->
+ <!-- Restore Guava to compile scope so that the libraries Spark depend on
have it available -->
Review Comment:
the existing comments are outdated, Hadoop already switched to
`hadoop-shaded-guava-1.2.0.jar`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
